-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Support Ephemeral dashboards on the UI #1790
Merged
Nexucis
merged 3 commits into
feat/ephemeral-dashboard
from
antoinethebaud/ephemeral-dashboard-front
Feb 28, 2024
Merged
[FEATURE] Support Ephemeral dashboards on the UI #1790
Nexucis
merged 3 commits into
feat/ephemeral-dashboard
from
antoinethebaud/ephemeral-dashboard-front
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b6ea9e0
to
e1e73b9
Compare
e1e73b9
to
7e4f108
Compare
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
7e4f108
to
d3cd7b7
Compare
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
Gladorme
reviewed
Feb 28, 2024
ui/app/src/components/EphemeralDashboardList/EphemeralDashboardDataGrid.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/dialogs/DeleteEphemeralDashboardDialog.tsx
Outdated
Show resolved
Hide resolved
ui/app/src/components/dialogs/DeleteEphemeralDashboardDialog.tsx
Outdated
Show resolved
Hide resolved
ui/dashboards/src/context/DashboardProvider/DashboardProvider.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
894e50e
to
3f9df46
Compare
Nexucis
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the display of Ephemeral dashboards on the UI.
NB: I made my best to share as much code as possible between Dashboards & Ephemeral Dashboards, I especially wanted to keep a single store & context for dashboards. It may still have room for improvement.
NB: Planned for later: add an option on the new duplicate action to make a dashboard copy ephemeral.
Ref issue #1729.
Screenshots
Checklist
[<catalog_entry>] <commit message>
naming convention using one of thefollowing
catalog_entry
values:FEATURE
,ENHANCEMENT
,BUGFIX
,BREAKINGCHANGE
,DOC
,IGNORE
.UI Changes
See Storybook
and e2e docs for more details. Common issues
include: