Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support Ephemeral dashboards on the UI #1790

Merged

Conversation

AntoineThebaud
Copy link
Contributor

@AntoineThebaud AntoineThebaud commented Feb 27, 2024

Description

Add the display of Ephemeral dashboards on the UI.

  • the new tab on the project view is not displayed if there are no ephemeral dashboards registered.
  • updating the TTL is possible from the project view, not the dashboard view. It's a design choice but there also a technical constraint (aka code genericity) preventing to allow modifying it from the JSON view in the current state.

NB: I made my best to share as much code as possible between Dashboards & Ephemeral Dashboards, I especially wanted to keep a single store & context for dashboards. It may still have room for improvement.

NB: Planned for later: add an option on the new duplicate action to make a dashboard copy ephemeral.

Ref issue #1729.

Screenshots

image
image
2024-02-27_21h52_10

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/ephemeral-dashboard-front branch from b6ea9e0 to e1e73b9 Compare February 27, 2024 15:45
@AntoineThebaud AntoineThebaud changed the title Support Ephemeral dashboards on the UI [FEATURE] Support Ephemeral dashboards on the UI Feb 27, 2024
@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/ephemeral-dashboard-front branch from e1e73b9 to 7e4f108 Compare February 27, 2024 15:55
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/ephemeral-dashboard-front branch from 7e4f108 to d3cd7b7 Compare February 27, 2024 21:40
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud marked this pull request as ready for review February 28, 2024 08:24
Signed-off-by: Antoine THEBAUD <antoine.thebaud@yahoo.fr>
@AntoineThebaud AntoineThebaud force-pushed the antoinethebaud/ephemeral-dashboard-front branch from 894e50e to 3f9df46 Compare February 28, 2024 11:03
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice !

@Nexucis Nexucis merged commit b67cc80 into feat/ephemeral-dashboard Feb 28, 2024
19 checks passed
@Nexucis Nexucis deleted the antoinethebaud/ephemeral-dashboard-front branch February 28, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants