Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Allow migration of empty panel dashboard #1854

Merged
merged 3 commits into from
Mar 29, 2024

Conversation

ying-jeanne
Copy link
Contributor

Description

Hi folks, I am first time contributor of this repo, not sure we are aligned the fix on this ticket #1536. This PR intent to allow migration of empty panels dashboard from Grafana, and remove the panels check in the schema of dashboard v1.

Screenshots

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • na Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • na Code follows the UI guidelines.
  • na Visual tests are stable and unlikely to be flaky.
    See Storybook
    and e2e docs for more details. Common issues
    include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

Signed-off-by: Ying WANG <ying.wang@grafana.com>
internal/api/migrate/mapping.cuepart Outdated Show resolved Hide resolved
pkg/model/api/v1/dashboard.go Outdated Show resolved Hide resolved
Signed-off-by: Ying WANG <ying.wang@grafana.com>
@Nexucis
Copy link
Member

Nexucis commented Mar 28, 2024

I think we can merge it right @AntoineThebaud ?

Once the log is removed, should be good to merge excepting if you have other comments @AntoineThebaud

Signed-off-by: Ying WANG <ying.wang@grafana.com>
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thank you @ying-jeanne !

@Nexucis Nexucis added this pull request to the merge queue Mar 29, 2024
Merged via the queue into perses:main with commit 083913c Mar 29, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants