[REFACTOR] Move TimeRangeControls/ToolbarIconButton respectively to plugin-system/components #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lugin-system/components Signed-off-by: Celian GARCIA <celian.garcia@amadeus.com>
celian-garcia
force-pushed
the
refactor/time-range-controls-move
branch
from
6b8f738
to
496e1d4
Compare
celian-garcia
commented
Mar 28, 2024
| @@ -12,7 +12,7 @@ | |||
| // limitations under the License. | |||
|
|
|||
| import { Stack, Box, useTheme, useMediaQuery } from '@mui/material'; | |||
| import { TimeRangeControls } from '@perses-dev/dashboards'; | |||
There was a problem hiding this comment.
All of it just to remove that single line 😄
celian-garcia
requested review from
Gladorme,
nicolastakashi and
AntoineThebaud
nicolastakashi
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that the
TimeRangeControlscomponent has been isolated, we can move it into plugin-system, alongside withTimeRangeProvider. This allows us to remove one of the@persesdev/dashboardimports from the explore. Step by step!linked with #1870
Screenshots
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes
See Storybook
and e2e docs for more details. Common issues
include: