fix: #208 isPersian replacing ه wit arabic ه (#225)

persian-tools · Jul 7, 2022 · 15bd04e · 15bd04e
1 parent 8f59246
commit 15bd04e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/modules/toPersianChars/index.ts b/src/modules/toPersianChars/index.ts
@@ -39,9 +39,8 @@ function toPersianChars(str: string): string | undefined {
 	str = str.replace(/ي/g, "ی");
 	str = str.replace(/ك/g, "ک");
 	str = str.replace(/ى/g, "ی");
-	str = str.replace(new RegExp("ه($|[^ء-يٱ-ە])", "g"), "ە$1");
+	str = str.replace(new RegExp("([^ء-يٱ-ە]|$)ه", "g"), "ە$1");
 	str = str.replace(/ە‌/g, "ە");
-	str = str.replace(/ه/g, "ھ");
 
 	// NOTE: This will also undo changes to categories which is not good
 	// but we will undo that later

diff --git a/test/isPersian.spec.ts b/test/isPersian.spec.ts
@@ -1,3 +1,4 @@
+import { toPersianChars } from "../src";
 import { isPersian, hasPersian } from "../src/modules/isPersian";
 
 it("isPersian", () => {
@@ -17,6 +18,11 @@ it("isPersian", () => {
 	expect(isPersian("")).toBeFalsy();
 });
 
+it("isPersian Bug#208, shah, mahdi", () => {
+	expect(isPersian(toPersianChars("مهدی") as string)).toBe(true);
+	expect(isPersian(toPersianChars("شاه") as string)).toBe(true);
+});
+
 it("hasPersian", () => {
 	expect(hasPersian("این یک متن فارسی است؟")).toBeTruthy();
 	expect(hasPersian("هل هذا نص فارسي؟")).toBeTruthy();