Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #208 isPersian replacing ه wit arabic ه #225

Merged
merged 1 commit into from
Jul 7, 2022

Conversation

pshaddel
Copy link
Contributor

@pshaddel pshaddel commented Jul 6, 2022

No description provided.

@ghost
Copy link

ghost commented Jul 6, 2022

👇 Click on the image for a new way to code review
  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #225 (04448d4) into master (24d6cec) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #225      +/-   ##
==========================================
- Coverage   92.81%   92.80%   -0.02%     
==========================================
  Files          43       43              
  Lines         682      681       -1     
  Branches      179      179              
==========================================
- Hits          633      632       -1     
  Misses         47       47              
  Partials        2        2              
Impacted Files Coverage Δ
src/modules/toPersianChars/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24d6cec...04448d4. Read the comment docs.

@ali-master ali-master added the bug Something isn't working label Jul 6, 2022
@ali-master ali-master changed the title fix: fix #208 isPersian replacing ه wit arabic ه Fix #208 isPersian replacing ه wit arabic ه Jul 7, 2022
@ali-master ali-master merged commit 15bd04e into persian-tools:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toPersianChars It does not work properly Missing Arabic character (toPersian)
2 participants