fix: TotalLiquidShares nil handling logic in slashing

Both TotalLiquidShares and TotalValidatorBondShares shouldn't be nil in state, this will be migrated in another place.
persistenceOne · Apr 25, 2023 · 64ac006 · 64ac006
1 parent 35f5aac
commit 64ac006
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/x/lsnative/staking/keeper/slash.go b/x/lsnative/staking/keeper/slash.go
@@ -131,7 +131,12 @@ func (k Keeper) Slash(ctx sdk.Context, consAddr sdk.ConsAddress, infractionHeigh
 	validator = k.RemoveValidatorTokens(ctx, validator, tokensToBurn)
 
 	// Proportionally deduct any liquid tokens from the global total
-	validatorLiquidRatio := validator.TotalLiquidShares.Quo(validator.DelegatorShares)
+	var validatorLiquidRatio sdk.Dec
+	if validator.TotalLiquidShares.IsNil() {
+		validatorLiquidRatio = sdk.ZeroDec()
+	} else {
+		validatorLiquidRatio = validator.TotalLiquidShares.Quo(validator.DelegatorShares)
+	}
 	slashedLiquidTokens := validatorLiquidRatio.Mul(sdk.NewDecFromInt(slashAmount)).TruncateInt()
 	k.DecreaseTotalLiquidStakedTokens(ctx, slashedLiquidTokens)