Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go.mod to v46, add groups. #383

Merged
merged 9 commits into from Mar 27, 2023
Merged

update go.mod to v46, add groups. #383

merged 9 commits into from Mar 27, 2023

Conversation

puneet2019
Copy link
Member

@puneet2019 puneet2019 commented Feb 16, 2023

1. Overview

update cosmos-sdk to v0.46.9

should I update sdk version to v3?

@puneet2019 puneet2019 removed the request for review from ajeet97 February 16, 2023 18:09
@puneet2019 puneet2019 marked this pull request as draft February 16, 2023 18:09
@github-actions
Copy link

Coverage after merging puneet/cosmosv46 into master

23.23%

Coverage Report
FileBranchesFuncsLinesUncovered Lines
simapp
   test_suite.go100%100%0%..., 52, 53, 54, 56
   genesis.go100%100%100%
   state.go100%100%0%..., 96, 97, 98, 99
   app.go100%100%78.71%..., 666, 667, 668, 669
   test_helpers.go100%100%22.38%..., 77, 78, 79, 81
   utils.go100%100%20.25%..., 96, 97, 98, 99
   genesis_account.go100%100%100%
   encoding.go100%100%100%
   config.go100%100%56.10%..., 72, 73, 74, 75
   export.go100%100%15.27%..., 93, 97, 98, 99
simapp/simd/cmd
   root.go100%100%81.94%..., 64, 65, 68, 69
   testnet.go100%100%79.44%..., 408, 409, 62, 63
   genaccounts.go100%100%71.54%..., 95, 96, 97, 98
x/epochs/client/cli
   query.go100%100%0%..., 95, 96, 97, 98
   tx.go100%100%0%..., 22, 23, 24, 25
x/epochs/keeper
   grpc_query.go100%100%38.46%..., 51, 53, 54, 55
   genesis.go100%100%90.91%14
   epoch.go100%100%85.71%..., 26, 62, 88, 93
   abci.go100%100%100%
   hooks.go100%100%100%
   keeper.go100%100%92.86%30
x/epochs/types
   query.pb.go100%100%2.24%..., 96, 97, 98, 99
   keys.go100%100%0%20, 21, 22
   genesis.pb.go100%100%28.80%..., 96, 97, 98, 99
   identifier.go100%100%0%..., 25, 7, 8, 9
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   hooks.go100%100%100%
   genesis.go100%100%59.18%..., 57, 58, 61, 62
x/halving/simulation
   genesis.go100%100%100%
   params.go100%100%100%
x/halving/types
   query.pb.gw.go100%100%0%..., 95, 96, 97, 98
   genesis.pb.go100%100%2.55%..., 68, 69, 98, 99
   genesis.go100%100%86.67%25, 26
   halving.pb.go100%100%2.76%..., 96, 97, 98, 99
   query.pb.go100%100%1.91%..., 96, 97, 98, 99
   params.go100%100%85.29%23, 24, 25, 43, 44
x/interchainquery
   handler.go100%100%40%16, 17, 18
   genesis.go100%100%54.55%21, 22, 23, 24, 25
   module.go100%100%62.50%..., 87, 90, 91, 92
x/interchainquery/keeper
   queries.go100%100%98%67
   keeper.go100%100%67.59%..., 43, 66, 67, 89
   msg_server.go100%100%65.08%..., 71, 74, 82, 83
   abci.go100%100%92.68%58, 59, 60
   grpc_query.go100%100%74.07%..., 33, 40, 43, 44
x/interchainquery/types
   keys.go100%100%0%28, 29, 30
   genesis.pb.go100%100%0.76%..., 996, 997, 998, 999
   msgs.go100%100%56%..., 42, 48, 49, 50
   query.pb.go100%100%1.32%..., 996, 997, 998, 999
   query.pb.gw.go100%100%0%..., 96, 97, 98, 99
   messages.pb.gw.go100%100%0%..., 92, 93, 95, 99
   messages.pb.go100%100%3.58%..., 96, 97, 98, 99
   codec.go100%100%100%
   genesis.go100%100%63.64%15, 16, 17, 18

@xlab xlab self-requested a review February 27, 2023 08:05
@xlab
Copy link
Contributor

xlab commented Feb 27, 2023

Sorry, reviewed wrong set of changes, also not sure why it appears in my review queue. Will wait till this is marked as ready.

@puneet2019
Copy link
Member Author

@xlab actually awaiting decision to ever support v46 :P , from me it is actually ready, I am using this branch as of now for pstake version update.

@puneet2019 puneet2019 marked this pull request as ready for review March 13, 2023 11:29
@xlab xlab requested a review from ajeet97 March 23, 2023 11:19
@puneet2019 puneet2019 merged commit 6729695 into master Mar 27, 2023
@xlab xlab deleted the puneet/cosmosv46 branch March 27, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants