Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LSM module (x/lsnative) to the app #187

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

xlab
Copy link
Contributor

@xlab xlab commented Apr 3, 2023

1. Overview

This PR includes an LSM module from persistence-sdk into the app. Nencessary package path replacements made.

2. Implementation details

It uses a special version github.com/persistenceOne/persistence-sdk/v2 v2.0.1-0.20230403194140-3773b08f31a1
that corresponds to persistenceOne/persistence-sdk#391 PR in persistence-sdk repo.

3. How to test/use

$ git clone git@github.com:persistenceOne/persistenceCore.git
$ git checkout max/add-lsnative
$ make install
$ cd scripts/
$ ./setup.sh
$ ./startup.sh

In a separate tab, while chain is running:

$ persistenceCore --keyring-backend=test tx --from=test --gas=auto --gas-adjustment=1.5 staking tokenize-share persistencevaloper1pkkayn066msg6kn33wnl5srhdt3tnu2v94kvz9 10000000stake persistence1pkkayn066msg6kn33wnl5srhdt3tnu2vv3k3tu --yes

$ persistenceCore q bank balances persistence1pkkayn066msg6kn33wnl5srhdt3tnu2vv3k3tu
balances:
- amount: "10000000"
  denom: persistencevaloper1pkkayn066msg6kn33wnl5srhdt3tnu2v94kvz9/1
- amount: "100000068117444"
  denom: stake
pagination:
  next_key: null
  total: "0"

4. Future Work (optional)

Adding an automatic e2e test that runs the app and uses an LSM scenario.

app/app.go Show resolved Hide resolved
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@xlab xlab merged commit fbabe57 into ajeet/sdk-v46 Apr 12, 2023
3 checks passed
@xlab xlab deleted the max/add-lsnative branch April 12, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants