Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-HTTP[S] links trigger the linked file feature. #39

Open
bharathcs opened this issue Aug 27, 2023 · 0 comments
Open

Non-HTTP[S] links trigger the linked file feature. #39

bharathcs opened this issue Aug 27, 2023 · 0 comments

Comments

@bharathcs
Copy link
Contributor

As far as I can tell, mailto links in canvas pages are treated as linked files, CanvasSync tries to download with that link and fails.

Here's an example of the canvas page html: <p><a href="mailto:*****@***.**">*****@***.**</a></p>
image

This is a pretty low impact bug in the mailto:... case (only results in a long list of failed file downloads). Might be a little bit worse if a file:// link is used (Didn't test, I'm not sure how the library would deal with a real local file present somewhere).

Fix should just be checking the URL scheme, and only going for the HTTP / HTTPS links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant