Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run script for easier setup #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DanielMSchmidt
Copy link
Contributor

Hey there,

This script should allow reruns and install everything a user needs, so that he can start right away 馃憤

Copy link
Contributor

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, I've added a few questions.

run.sh Outdated

set -e

if [ -d "$DIRECTORY" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's $DIRECTORY?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we don't need that anymore 馃

run.sh Outdated

if [ -d "$DIRECTORY" ]; then
echo 'Cloning roles'
git clone git@github.com:personal-provisioning/roles.git ../roles
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why clone it into ../roles. The last approach was to clone it into ~/.personal_provisioning/roles, so we can use this patch in our ansible config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A standardized way makes sense, you are right 馃憤 will change it

3. Init git again `git init`
4. Run `setup.sh`
1. Setup the directory strucutre: `mkdir -p ~/.personal_provisioning`
2. Clone this repo `git clone https://github.com/personal-provisioning/starterkit.git ~/.personal_provisioning/config`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't really have to specify this. You can clone it anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, will change it 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants