Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the setting place of path where event log is saved. #126

Closed
SawamiWataru opened this issue Feb 7, 2018 · 3 comments · Fixed by #677
Closed

Unify the setting place of path where event log is saved. #126

SawamiWataru opened this issue Feb 7, 2018 · 3 comments · Fixed by #677
Milestone

Comments

@SawamiWataru
Copy link
Contributor

SawamiWataru commented Feb 7, 2018

Current specifications.

  • When creating log
    • Refer to "eventlog_path" in logback.xml
  • When log is acquired
    • Refer to "io.personium.core.event.log.current.dir" in personium-unit-config.properties

eventログの書き込みと読み込みでそれぞれ異なる設定箇所のPathを参照している。
今はデフォルトで同一の設定になっているので問題ないが、ユーザがどちらかを修正すると正常に動作しなくなる。
修正:https://github.com/KourokiTakuto/personium-core/commit/1b2aa0735b05da3fbc7243f00f1d860afe1821c7 でcoreとしての修正は完了しているが、logback.xmlの修正によりansibleにも影響が出る。同時にリリースが必要。

@SawamiWataru
Copy link
Contributor Author

It is difficult to fix where you are reading logback.xml.
I think that the following policy is good.

  • Remove setting from personium-unit-config.properties
  • Read log setting from logback.xml

The related sources are as follows.

  • io.personium.core.event.EventUtils.getEventLogDir()
  • io.personium.core.rule.action.LogAction

@KourokiTakuto
Copy link
Contributor

The logback.xml setting value variable has been modified to refer to personium-unit-config.properties.
It is necessary to modify "Ansible" logback.xml.
Correct it also when modifying large "Ansible".

@yoh1496
Copy link
Contributor

yoh1496 commented Oct 4, 2022

How about making eventlog_path contain /personium_nfs/personium-core/eventlog/ and pass entire event log path which is loaded from personium-unit-config.properties ?

https://github.com/personium/personium-core/blob/v1.8.1/src/main/resources/logback.xml#L62

before

<file>/personium_nfs/personium-core/eventlog/${eventlog_path}/current/default.log</file>

after

<file>${eventlog_path}/current/default.log</file>

https://github.com/personium/personium-core/blob/v1.8.1/src/main/java/io/personium/core/rule/action/LogAction.java#L80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants