Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should respond error when accessed via domain name different from the one configured in Unit Certificate #535

Closed
shimono opened this issue Dec 11, 2019 · 1 comment · Fixed by #560
Closed

Should respond error when accessed via domain name different from the one configured in Unit Certificate #535

shimono opened this issue Dec 11, 2019 · 1 comment · Fixed by #560
Assignees
@shimono
Projects
Current Work
Milestone
1.7.22

Comments

@shimono
Copy link
Member

shimono commented Dec 11, 2019 •
edited

Overview

Core should respond with 400 error when accessed via domain name different from the one configured in Unit Certificate.

Why this feature

This is necessary to avoid such cases where a unit operator fails to configure the unit certificate without knowing about it and face Token Dsig error when exchanging TransCell Access Tokens.

With this feature unit owner can immediately know if the unit is misconfigured.
@shimono shimono self-assigned this Mar 5, 2020
@shimono shimono added this to the next-candidate milestone Mar 5, 2020
@shimono shimono added this to Backlog in Current Work via automation Mar 5, 2020
@shimono
Copy link
Member Author

shimono commented Mar 5, 2020

Implementation should be applied probably on FacadeResource ?

shimono added a commit to shimono/personium-core that referenced this issue Mar 5, 2020
@shimono
fix personium#535
65ea886
shimono added a commit to shimono/personium-core that referenced this issue Mar 6, 2020
@shimono
fix personium#535
19cc48e
@shimono shimono moved this from Backlog to In progress (today) in Current Work Mar 6, 2020
@shimono shimono moved this from In progress (today) to Review in progress in Current Work Mar 9, 2020
@dixonsiu dixonsiu modified the milestones: next-candidate, 1.7.22 Mar 9, 2020
@shimono shimono linked a pull request Mar 9, 2020 that will close this issue
Feature #535: Should respond error when accessed via domain name different from the one configured in Unit Certificate #560
Merged
Current Work automation moved this from Review in progress to Done Oct 2, 2020
tochi-y added a commit that referenced this issue Oct 2, 2020
@tochi-y
Merge pull request #560 from shimono/feat-535-respond-error-when-non-…
f4250d0 
…unit-fqdn-access

Feature #535: Should respond error when accessed via domain name different from the one configured in Unit Certificate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shimono shimono

Labels
None yet
Projects
Current Work
  
Done
Milestone
1.7.22
2 participants
@shimono @dixonsiu