Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sign API #625

Merged
merged 10 commits into from
Mar 29, 2022
Merged

Add sign API #625

merged 10 commits into from
Mar 29, 2022

Conversation

yoh1496
Copy link
Contributor

@yoh1496 yoh1496 commented Jan 28, 2022

Implemented sign API

I implemented SignResource class to sign contents with private key which cell has.

The sign API has below features.

  • The endpoint is __sign.
  • The endpoint is executed with token having p:sign privilege.
  • Response with Content-Type application/jose and contains a text formated JWS Compact Serialization .
  • The JWS text can be verified with a key which can be fetch from __certs .

Other changes

  • Refactoring classes around private key of cell.
  • Add some test classes for sign API.
  • Add p:sign privilege.

Could you review this?

@tochi-y tochi-y added this to In progress (today) in Current Work via automation Feb 1, 2022
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
Copy link
Member

@tochi-y tochi-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tochi-y tochi-y merged commit cdc90ce into personium:develop Mar 29, 2022
Current Work automation moved this from In progress (today) to Done Mar 29, 2022
@yoh1496 yoh1496 deleted the feature/sign branch September 5, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Current Work
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants