Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple AuthPlugin support and some fixes. #23

Merged
merged 8 commits into from
Sep 29, 2021

Conversation

yoh1496
Copy link
Contributor

@yoh1496 yoh1496 commented Aug 13, 2021

This PR contains below.

Multiple AuthPlugin Support

To load multiple instances by one class, AuthPluginLoader interface is added.
By implementing AuthPluginLoader containing loadInstances() , you can load multiple AuthPlugin onto Personium unit.

some fixes

  • modifing headers.
  • Replace CachingHttpClient with CachingHttpClientBuilder.
  • If properties file is not found, throw exception.

@tochi-y tochi-y self-assigned this Aug 18, 2021
@tochi-y tochi-y added this to In progress (today) in Current Work via automation Aug 18, 2021
Copy link
Member

@tochi-y tochi-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoh1496 I added comments. Please check them, thanks.

@tochi-y tochi-y merged commit d013f03 into personium:develop Sep 29, 2021
Current Work automation moved this from In progress (today) to Done Sep 29, 2021
@yoh1496
Copy link
Contributor Author

yoh1496 commented Sep 30, 2021

Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Current Work
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants