Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ganache-cli in CI pipeline #4

Closed
wants to merge 3 commits into from
Closed

ganache-cli in CI pipeline #4

wants to merge 3 commits into from

Conversation

ggwpez
Copy link
Contributor

@ggwpez ggwpez commented Apr 29, 2020

Trying to get the TestNodes test working.

@ggwpez
Copy link
Contributor Author

ggwpez commented Apr 29, 2020

As long as this bug is not fixed, the automated node testing does not work.
We either 1. Fork go-prompt,
2. Use the TestAPI RPC to send the commands instead of goexpect,
3. wait for c-bata to merge it 🛌

@sebastianst
Copy link
Contributor

I pushed this problem in the go-prompt repo (c-bata/go-prompt#39). I propose that we wait a bit for him to hopefully fix it soon.

@matthiasgeihs
Copy link
Contributor

i experimented with replacing goexpect by some simple os/exec logic. this failed, however, because go-prompt is used in the demo and this relies on the low level system specific implementation and does not use the regular stdin stdout for interfacing with the command line user.

@ggwpez
Copy link
Contributor Author

ggwpez commented Jan 11, 2021

Ci got fixed in #26

@ggwpez ggwpez closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants