-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First channel #3
Conversation
2240469
to
7f4bb79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! Mostly minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my replies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved almost all conversations. Mostly this one remains and needs your input:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the commit message of 1f56bd3 (iamge -> image)
You can squash and merge then.
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
- Remove the commands section - Explain the -p 1 test flag Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
The CI fails on purpose until the annoying
GenericBackendTest
thing is fixed (hyperledger-labs/go-perun#227), everything else works.