Refactor: Process potential events from transaction output #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface, add EventType field. Add GetType() method to show event type. Add Assert...Event functions to test for events related to contract calls. * refactor(client): Add checks for events after contract calls. Also add error handling for cases in which events are not triggered during the present call. * refactor(channel): Adapt to changes in event package.
… error in this place. * refactor(client): Add ErrCouldNotDecodeTxMeta to use it in InvokeAndProcessHostFunction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves event handling after reading out the transaction output in the client package.
This improves security and handles edge cases in which some contract functions are called multiple times.
Contract calls to not trigger events if the call has been made before. For instance, when a
closehas been made, a subsequentclosecall will result in an error and will not emit a contract event. This PR handles such cases gracefully.