sync: Add ServiceGroup implementation #15
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're often in a situation where we want to start several services in goroutines and then wait for either all of them to return with a
nil
error or the first to return a non-nil
error. So far, we usually either use a bare error channel in such situations or theerrors.Gatherer
together withWaitDoneOrFail
. However, theGatherer
has a rather bloated implementation with several mutexes and other synchronization state and its multi-error feature doesn't help in such situations because there will only be one error once the first routine fails.So I propose to add a lightweight implementation
ServiceGroup
that covers this exact use case. It is an eagerly-finishing version of thegolang.org/x/sync/errgroup.Group
, which always waits for all routines to return.Don't merge yet, untested and intended as a base for discussion.