404 if I return response.body()

[kliakos]

Hi, why do I get a 404 if I do this?

get("hello", (request, response) -> {
    response.body("Hello");

    return response.body();
});

404 Not found
The requested route [/hello] has not been mapped in Spark

[perwendel]

You don't explain how you try to access the resource. Have you tried adding a slash before hello ie.

get("/hello", (...

[kliakos]

Yes, I have tried both paths, "hello" and "/hello". When I access http://localhost:4567/hello, I get the 404 in both cases

[perwendel]

The code inside your method is strange, however that doesn't explain the behavior. Are your running it standalone or in another web app server like tomcat? Have you tried just returning "Hello World";?

[kliakos]

If I return any other string, it works fine. If I return the response.body()(which is a String), it gives the 404.

I am running this simple test with the built in Jetty container.

[perwendel]

This is because calling response.body() the invocation in ResponseWrapper is not delegated. I'm not sure why this is not done. However, It's not encouraged to use body(string) from Routes since the return value is used. It's supposed to be used from the filters where the return type is Void.

[kliakos]

Clear enough.

Reading the http://www.sparkjava.com/readme.html#title4 you get the impression that this is the standard way you define the response body.

From code examples thought it is pretty clear that the example I have mentioned is never used and discouraged.

You can close this issue if you want.

[perwendel]

Yep, I might need to clarify that section and also fix the bug so it can be used from within Routes. I hope all the other documentation in the README section inspires users to use the return value.