Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider opening up jetty replacement with other custom server: #288

Closed
gencube opened this issue Jun 4, 2015 · 10 comments
Closed

Comments

@gencube
Copy link

gencube commented Jun 4, 2015

HI,

public class MyNetworkServer implements NetworkServer {
}

...
// just like in port and before port(8080)
server(new MyNetworkServer());

That way, we can write a hook to replace jetty with an even better server or Custom server like Netty or Undertow.

@gencube
Copy link
Author

gencube commented Jun 4, 2015

This is Related to this issue:
#289

@kliakos
Copy link
Contributor

kliakos commented Jun 4, 2015

+1 for undertow

@gencube
Copy link
Author

gencube commented Jun 4, 2015

Undertow is what I am thinking about.

@jacek99
Copy link

jacek99 commented Jun 4, 2015

Personally, I would really prefer that Spark gets split into 2 totally separate project: a REST router with no server dependencies at all AND then a separate all-in-one combo with an embedded server.

If we have the first part (i.e. standalone REST router) then we could embed it in our existing Dropwizard services and get rid of Jersey

@gencube
Copy link
Author

gencube commented Jun 5, 2015

Personally, I would really prefer that Spark gets split into 2 totally separate project: a REST router with no server dependencies at all AND then a separate all-in-one combo with an embedded server. << Hear Hear!

@jhernandezb
Copy link

+1 for split

1 similar comment
@rygel
Copy link

rygel commented Jun 9, 2015

+1 for split

@r1j0
Copy link

r1j0 commented Jun 15, 2015

+1

1 similar comment
@beihaifeiwu
Copy link

+1

@tipsy
Copy link
Contributor

tipsy commented Mar 3, 2017

Considering it. We already have some other issues and PRs for this, so closing this one.

@tipsy tipsy closed this as completed Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants