Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for Base64.decode and Base64.encode #1257

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add test for Base64.decode and Base64.encode #1257

wants to merge 2 commits into from

Conversation

lacinoire
Copy link

Hey 馃槉
I want to contribute a test.
Curious to hear what you think!

(I wrote this test as part of a research study at TU Delft. Find out more)

asolntsev
asolntsev suggested changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually every unit-test should verify only one method. I would split your test into two: one for encode and other for decode.

@lacinoire
Copy link
Author

Good point, I've split it into one test each.

@lepe lepe mentioned this pull request Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asolntsev asolntsev asolntsev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lacinoire @asolntsev