Refactoring in findTargetWithGivenAcceptType #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm trying to validate. A question: |
|
Hi, MimeParse.bestMatch(acceptedMimeTypes.keySet(),acceptType); returns NO_MIME_TYPE if it fails and routeWithGivenAcceptType only verifies that the return of this operation is not equal to NO_MIME_TYPE to perform an operation on the map, I believe that this operation can be performed without any check as if the key does not exist on the map return the operation will be null. Correct ? |
| if (acceptType != null && routeMatches.size() > 0) { | ||
|
|
||
| if (routeMatches.isEmpty()) { | ||
| return null; |
There was a problem hiding this comment.
can "routeMatches" can be null? if spark has apache commons use CollectionUtils.isEmpty() else, just check list is null too
|
Class has been deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I made a refactoring in findTargetWithGivenAcceptType method. All tests are passing, can validate please? Thank U.
Tests run: 69, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------