SparkServer was updated to be runnable on http and https protocols at… #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… same time. Api call was added to SparkBase to support that. Ability to specify special ssl port and justSsl flag were added.
|
When is supposed this to be merged? I need this. |
| protected static final String DEFAULT_ACCEPT_TYPE = "*/*"; | ||
|
|
||
| protected static boolean initialized = false; | ||
|
|
||
| protected static int port = SPARK_DEFAULT_PORT; | ||
| protected static int sslPort = SPARK_DEFAULT_PORT; |
There was a problem hiding this comment.
Should't sslPort have the value of SPARK_DEFAULT_PORT_SSL?
|
+1 |
Conflicts: src/main/java/spark/SparkBase.java src/main/java/spark/webserver/SparkServer.java
|
Pull request was synced with latest code base. |
|
Where exactly is it synchronized? In the master code base I can not find the string 'SPARK_DEFAULT_PORT_SSL' neither the 'sslPort' variable? |
|
It was better to say that it is redone. @georgeyanev Please see commit e1b6144 |
Closed
|
@gimlet2 Is this feature is available in 2.5.3 release? I need this feature ASAP. thanks |
|
Is this issue still relevant now when there's an instance API? Service http = ignite()
Service https = ignite()
http.port(1234)
https.port(1235)
https.secure(... |
|
As per mentioned, I think this should be taken care of by the instance-api, or in a layer in front of Spark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… same time. Api call was added to SparkBase to support that. Ability to specify special ssl port and justSsl flag were added.