Updated Jetty dependency and a test broken by Jetty changes.

[jakaarl]

See issue: #694

[ph-hs]

9.4.0.v20161208 is out now.

[ph-hs]

9.4.0.v20161208 is out now

[jakaarl]

@ph-hs I noticed, started updating the pull request last night, but there were complications.

[paul-hammant]

It is interesting that it is only the test that's broken with the Jetty upgrade. In real life, you can do the maven thing and deploy Spark with the 9.4.x of Jetty quite happily.

[paul-hammant]

The bits that you're stuck on could be, solved by:

-        WebSocketUpgradeFilter webSocketUpgradeFilter =
-                (WebSocketUpgradeFilter) servletContextHandler.getAttribute("org.eclipse.jetty.websocket.server.WebSocketUpgradeFilter");
+        WebSocketUpgradeFilter webSocketUpgradeFilter = (WebSocketUpgradeFilter) servletContextHandler.getServletHandler().getFilter("Jetty_WebSocketUpgradeFilter").getFilter();

and

-        WebSocketServerFactory webSocketServerFactory = webSocketUpgradeFilter.getFactory();
+        WebSocketServerFactory webSocketServerFactory = webSocketUpgradeFilter.getConfiguration().getFactory();

and

-         MappedResource<WebSocketCreator> mappedResource = webSocketUpgradeFilter.getMappings().getMatch("/websocket");
+        MappedResource<WebSocketCreator> mappedResource = webSocketUpgradeFilter.getConfiguration().getMatch("/websocket");

[jakaarl]

Thanks, I'll take a look tonight. I got burned by not getting the upgrade filter from the attributes and didn't have the time/energy to research into it last night.

[ph-hs]

One of the unrelated tests is now failing:

testDirectoryTraversalProtectionLocal(spark.staticfiles.StaticFilesTest)  Time elapsed: 0.13 sec  <<< FAILURE!
java.lang.AssertionError: expected:<404> but was:<400>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at spark.staticfiles.StaticFilesTest.testDirectoryTraversalProtectionLocal(StaticFilesTest.java:145)

Needs to be investigated, I think.

[jakaarl]

Seems the unexpected response comes all the way from Jetty:
WARN org.eclipse.jetty.http.HttpParser - bad HTTP parsed: 400 Bad URI for HttpChannelOverHttp@4db7b425{r=1,c=false,a=IDLE,uri=//localhost:4567/..%5Cspark%5CSpark.class}

[tipsy]

@jakaarl would be great if you could have a look at this again.
Edit: I changed the behavior of the director-traversal code to return 400, which seems more appropriate anyway. Hopefully I'm not hiding a bug now.
Thanks @jakaarl and @paul-hammant