Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further modernization, removing six #166

Merged
merged 11 commits into from Jan 30, 2024
Merged

Further modernization, removing six #166

merged 11 commits into from Jan 30, 2024

Conversation

bmcfee
Copy link
Collaborator

@bmcfee bmcfee commented Jan 30, 2024

This PR continues the modernization effort by removing six and lingering references to python 2 support.

Once we're in the green, I'll also do some code style updates.

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e4f6b68) 97.46% compared to head (4c90883) 97.80%.

Files Patch % Lines
pescador/mux.py 86.84% 5 Missing ⚠️
pescador/core.py 83.33% 1 Missing ⚠️
pescador/util.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   97.46%   97.80%   +0.33%     
==========================================
  Files           8        8              
  Lines         553      546       -7     
==========================================
- Hits          539      534       -5     
+ Misses         14       12       -2     
Flag Coverage Δ
unittests 97.80% <91.25%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmcfee bmcfee merged commit 0077927 into main Jan 30, 2024
10 of 11 checks passed
@bmcfee bmcfee deleted the deep-six branch January 30, 2024 15:19
@bmcfee bmcfee mentioned this pull request Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant