Fixes #87 #97
Merged
Fixes #87 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hardest fought 13 lines of code in some time, ugh |
cjacoby
approved these changes
Jun 14, 2017
There was a problem hiding this comment.
I'd like to see, down the road, some more actual "unit" tests for Muxes which actually introspect the internal state of the mux, and make sure it's functions do what they're supposed to do.
But, barring that somewhat major endeavor, probably related to #96, I think this is good.
|
thx for the looksee! agreed on the state-based testing ... i'll add an issue, and then we can decide if it's 1.1 milestone territory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to avoid infinite loops on empty streams, issue #87