Removing deprecated method calls from README #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congrats on your first PR and here's to many more of them to come! 馃帀 I've got to admit that it's both embarrassing to have such blatant mistakes right in the README, but also rewarding when you leave a small gap for others to have a chance to fill. |
bors bot
added a commit
that referenced
this pull request
Feb 17, 2019
371: Removing deprecated method calls from README r=dragostis a=adamAndMath The readme file contained calls to ['Pair::into_span'](https://docs.rs/pest/2.1.0/pest/iterators/struct.Pair.html#method.into_span), witch were deprecated in 2.0.0. I have replaced calls to ['into_span'](https://docs.rs/pest/2.1.0/pest/iterators/struct.Pair.html#method.into_span) with ['as_span'](https://docs.rs/pest/2.1.0/pest/iterators/struct.Pair.html#method.as_span), as well as calling ['pair::as_str'](https://docs.rs/pest/2.1.0/pest/iterators/struct.Pair.html#method.as_str) directly instead of the ['span::as_str'](https://docs.rs/pest/2.1.0/pest/struct.Span.html#method.as_str). This is my first pull request to any open source project. So I hope I've done this right 馃槄 Co-authored-by: Adam <adam.and.math@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme file contained calls to 'Pair::into_span', witch were deprecated in 2.0.0.
I have replaced calls to 'into_span' with 'as_span', as well as calling 'pair::as_str' directly instead of the 'span::as_str'.
This is my first pull request to any open source project. So I hope I've done this right 馃槄