Fix incorrect align when underlining lines with tab... #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...character Fixes pest-parser#407
|
This looks fine to me. r? @dragostis |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 24, 2019
408: Fix incorrect align when underlining lines with tab... r=dragostis a=cr0sh ...character Fixes #407 Note: `Error::underline` now prints not only prefixes space but tabs if underlining line contains it, so I'm concerned about if this commit breaks backwards compatibility. Co-authored-by: Nam Jeonghyun <ska827@naver.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...character
Fixes #407
Note:
Error::underlinenow prints not only prefixes space but tabs if underlining line contains it, so I'm concerned about if this commit breaks backwards compatibility.