Don't enable std feature on sha-1 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because cargo sucks. rust-lang/cargo#4866
|
bors: r+ @dragostis, can we get a patch version published with this? |
bors bot
added a commit
that referenced
this pull request
Aug 20, 2019
410: Don't enable std feature on sha-1 r=CAD97 a=roblabla I'm currently working on a no_std project that uses Pest in a proc macro, and also uses sha1 somewhere else in the crate graph. It uses sha1 in nostd mode. But because cargo ~~sucks~~ has [some really broken behavior](rust-lang/cargo#4866) around build and dev dependencies, pest ends up activating the std feature for my build. Pest doesn't really need the std feature of SHA-1 anyways. So this PR disables it. Co-authored-by: Robin Lambertz <github@roblab.la>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently working on a no_std project that uses Pest in a proc macro, and also uses sha1 somewhere else in the crate graph. It uses sha1 in nostd mode. But because cargo
suckshas some really broken behavior around build and dev dependencies, pest ends up activating the std feature for my build.Pest doesn't really need the std feature of SHA-1 anyways. So this PR disables it.