Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all clippy warnings and errors #555

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Fix all clippy warnings and errors #555

merged 4 commits into from
Jul 19, 2022

Conversation

NoahTheDuke
Copy link
Member

@NoahTheDuke NoahTheDuke commented Oct 20, 2021 •
edited
Loading

Didn't touch any of the allow clippy directives, but maybe I should take a look at those too.

Removed unnecessary clippy directives too.

CAD97
CAD97 requested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@CAD97 CAD97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good except for a double check on the application of De Morgan's here

pest/src/macros.rs Outdated Show resolved Hide resolved
pest/src/macros.rs Outdated Show resolved Hide resolved
pest/src/macros.rs Outdated Show resolved Hide resolved
pest/src/macros.rs Outdated Show resolved Hide resolved
pest/src/macros.rs Outdated Show resolved Hide resolved
pest/src/macros.rs Outdated Show resolved Hide resolved
pest/src/macros.rs Outdated Show resolved Hide resolved
vm/src/macros.rs Outdated Show resolved Hide resolved
vm/src/macros.rs Outdated Show resolved Hide resolved
vm/src/macros.rs Outdated Show resolved Hide resolved
CAD97
CAD97 requested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@CAD97 CAD97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One important nit to be addressed (and maybe that address is just "well that's not necessary anymore"), then this looks good to merge

generator/src/generator.rs Outdated Show resolved Hide resolved
generator/src/generator.rs Outdated Show resolved Hide resolved
@NoahTheDuke NoahTheDuke force-pushed the nb/clippy-fixes branch 2 times, most recently from f17da19 to 3ff64a9 Compare October 21, 2021 02:54
@NoahTheDuke NoahTheDuke mentioned this pull request Oct 22, 2021
Closed
CAD97
CAD97 approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@CAD97 CAD97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the huge delay!

@CAD97 CAD97 merged commit 9b7192b into pest-parser:master Jul 19, 2022
@NoahTheDuke NoahTheDuke deleted the nb/clippy-fixes branch July 19, 2022 18:35
@CAD97 CAD97 mentioned this pull request Jul 19, 2022
Merged
@NoahTheDuke
Copy link
Member Author

No worries, life has gotten very busy for me too.

@tomtau
Copy link
Contributor

tomtau commented Jul 19, 2022

@NoahTheDuke I saw this follow up PR: #559 -- will you try to re-open it?

@NoahTheDuke
Copy link
Member Author

I replied to you in that PR to keep things organized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAD97 CAD97 CAD97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NoahTheDuke @tomtau @CAD97