Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undo https://github.com/pest-parser/pest/pull/522 #673

Merged
merged 2 commits into from
Jul 29, 2022
Merged

fix: undo https://github.com/pest-parser/pest/pull/522 #673

merged 2 commits into from
Jul 29, 2022

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Jul 29, 2022

closes #672

  • bumped version numbers and split up the release flow as a workaround for a bug in katyo/publish-crates GH action

@tomtau tomtau requested a review from a team as a code owner July 29, 2022 15:58
@tomtau tomtau requested review from NoahTheDuke and removed request for a team July 29, 2022 15:58
NoahTheDuke
NoahTheDuke approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@NoahTheDuke NoahTheDuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks good to me, I'll trust you on the GH Actions change.

@NoahTheDuke
Copy link
Member

This makes me think we need some way to automate updating the version numbers lol. A lot of places to change every time we cut a new release.

@tomtau tomtau mentioned this pull request Jul 29, 2022
Closed
MarijnS95
MarijnS95 approved these changes Jul 29, 2022
View reviewed changes
Copy link

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton, tested and this fixes #672 :)

@tomtau tomtau merged commit d1935d4 into pest-parser:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahTheDuke NoahTheDuke NoahTheDuke approved these changes

@MarijnS95 MarijnS95 MarijnS95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking changes in latest release
3 participants
@tomtau @NoahTheDuke @MarijnS95