Fix #838 grammar error when only have //!, /// or //, allow writing empty pest grammar.
#839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huacnlee
commented
Apr 17, 2023
| @@ -16,102 +16,126 @@ | |||
| //! future (e.g. by increasing MSRV and non_exhaustive annotations). | |||
|
|
|||
| /// The top-level rule of a grammar. | |||
| grammar_rules = _{ SOI ~ grammar_doc* ~ (grammar_rule)+ ~ EOI } | |||
| grammar_rules = _{ SOI ~ grammar_doc* ~ grammar_rule* ~ EOI } | |||
There was a problem hiding this comment.
This first just changed this line from (grammar_rule)+ to grammar_rule*.
The other changes were made by pest-fmt format.
huacnlee
commented
Apr 17, 2023
| @@ -1171,7 +1171,7 @@ mod tests { | |||
| parser: PestParser, | |||
| input: "0", | |||
| rule: Rule::grammar_rules, | |||
| positives: vec![Rule::grammar_rule, Rule::grammar_doc], | |||
| positives: vec![Rule::EOI, Rule::grammar_rule, Rule::grammar_doc], | |||
There was a problem hiding this comment.
Because the grammar_rules now is not requirement at least one grammar rule, so this test need to change.
huacnlee
changed the title
//!, /// or //.//!, /// or //, allow writing empty pest grammar.
NoahTheDuke
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.