Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix for cargo-msrv needing at least 1.59 now #850

Merged
merged 1 commit into from
Apr 28, 2023
Merged

ci: fix for cargo-msrv needing at least 1.59 now #850

merged 1 commit into from
Apr 28, 2023

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Apr 28, 2023

No description provided.

@tomtau tomtau requested a review from a team as a code owner April 28, 2023 02:22
@tomtau tomtau requested review from NoahTheDuke and removed request for a team April 28, 2023 02:22
@tomtau tomtau mentioned this pull request Apr 28, 2023
Merged
7 tasks
@tomtau tomtau merged commit 2a97516 into pest-parser:master Apr 28, 2023
@tomtau tomtau deleted the fix/ci-msrv branch April 28, 2023 05:26
@Tartasprint
Copy link
Contributor

Isn't updating the rust-version in each Cargo.toml also necessary ?

@Tartasprint Tartasprint mentioned this pull request Apr 30, 2023
Closed
@tomtau
Copy link
Contributor Author

tomtau commented May 1, 2023

@Tartasprint no, pest's MSRV is still 1.56... this one was for building the cargo-msrv tool which is for checking MSRV (and the tool itself requires 1.59 to build it, but it can check lower MSRV AFAIK)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahTheDuke NoahTheDuke Awaiting requested review from NoahTheDuke NoahTheDuke is a code owner automatically assigned from pest-parser/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomtau @Tartasprint