Implement Display for Expr and OptimizedExpr #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not related changes included in previous pull request pest-parser#895.
TheVeryDarkness
requested review from
NoahTheDuke
and removed request for
a team
tomtau
approved these changes
Jul 20, 2023
tomtau
reviewed
Jul 20, 2023
Comment on lines
+279
to
+280
| nodes.push(lhs); | ||
| current = rhs; |
There was a problem hiding this comment.
it seems this bit isn't covered by tests (also not covered in Choice); I'm fine to merge it as it is though
There was a problem hiding this comment.
I'll add several tests for that then. Sorry to forget that.
There was a problem hiding this comment.
No problem, it should be ok as it is
To cover more paths in Seq and Choice. Thanks for @tomtau to point it out in pest-parser#896.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-related changes included in previous pull request #895.
Improve the implementation added in #889.
Corresponding tests added.