Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share button depends on discontinued service #9

Closed
nathanielknight opened this issue Jun 4, 2020 · 4 comments · Fixed by #36
Closed

Share button depends on discontinued service #9

nathanielknight opened this issue Jun 4, 2020 · 4 comments · Fixed by #36
Labels
help wanted Extra attention is needed

Comments

@nathanielknight
Copy link
Contributor

The Share button for the online editor depends on myjson.com, but it appears that that service has been discontinued.
@singalen
Copy link

Is this the reason why old editor snippet references are not working, or is that a separate issue?

@CAD97
Copy link

CAD97 commented Apr 8, 2021

Yep, this is the reason that share links no longer work.

@nathanielknight
Copy link
Contributor Author

This could probably be fixed by base64-encoding the data and storing it in the URL (though it would make for big URLs if the grammar is big). It might be a hassle to make it backwards compatible, but that might not matter if old links won't work anyways?

I could take a stab at this if it would be of interest.

@tomtau tomtau added the help wanted Extra attention is needed label Nov 24, 2022
@tomtau
Copy link
Contributor

tomtau commented Nov 24, 2022

or use another service (e.g. https://jsonserve.com )?

nathanielknight added a commit to nathanielknight/site that referenced this issue Nov 27, 2022
@nathanielknight
Fix share button
c064db3 
This commit replaces the current editor share button (which depends on a
discontinued service, per pest-parser#9) with a version that

* grabs the grammar from the editor
* base64-encodes it, and
* stores it in a URL

It also adds code that checks for a grammar during page load and inserts
it into the editor.

This lets folks create self-contained share links as long as there are
no breaking changes in the grammar format, which I think is the right
tradeoff for an online playground-style editor.

Fixes pest-parser#9
nathanielknight added a commit to nathanielknight/site that referenced this issue Nov 27, 2022
@nathanielknight
Fix share button
bd9da10 
This commit replaces the current editor share button (which depends on a
discontinued service, per pest-parser#9) with a version that

* grabs the grammar from the editor
* base64-encodes it, and
* stores it in a URL

It also adds code that checks for a grammar during page load and inserts
it into the editor.

This lets folks create self-contained share links as long as there are
no breaking changes in the grammar format, which I think is the right
tradeoff for an online playground-style editor.

Fixes pest-parser#9
@nathanielknight nathanielknight mentioned this issue Nov 27, 2022
Closed
@nathanielknight nathanielknight mentioned this issue Mar 4, 2023
Merged
@tomtau tomtau closed this as completed in #36 Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

URL-based share button nathanielknight/site
WIP Fix share button nathanielknight/site
4 participants
@singalen @nathanielknight @tomtau @CAD97