Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken assertions link in help #2205

Merged
merged 1 commit into from Oct 3, 2022
Merged

Fix broken assertions link in help #2205

merged 1 commit into from Oct 3, 2022

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented Jun 30, 2022

PR Summary

Fixes a broken link in Should help for the custom assertions page at https://pester.dev/docs/assertions.

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@fflaten
Copy link
Collaborator Author

fflaten commented Jun 30, 2022

@bravo-kernel Why doesn't this use assertions/assertions anymore? Special because it's named the same as the folder?

@bravo-kernel
Copy link
Collaborator

My best guess would be that this is some sort new Docusaurus behavior for same/same pages. IIRC people had been asking for that logic for some time and I must say, it feels logical to me. Anyway, should be easy to verify by creating introduction/introduction or sth. Can try this weekend unless you beat me to it.

@fflaten
Copy link
Collaborator Author

fflaten commented Jun 30, 2022

Determining projects to restore...
  Restored D:\a\1\s\src\csharp\Pester\Pester.csproj (in 42.26 sec).
  Restored D:\a\1\s\src\csharp\PesterTests\PesterTests.csproj (in 2 min).

😠

@azure-pipelines
Copy link
Contributor

Command 'run
Determining' is not supported by Azure Pipelines.<br>
<br>
<b>Supported commands</b><br>
<ul type="none"><li><b>help:</b></li><ul type="none"><li>Get descriptions, examples and documentation about supported commands</li><li><b>Example: </b>help "command_name"</li></ul><li><b>list:</b></li><ul type="none"><li>List all pipelines for this repository using a comment.</li><li><b>Example: </b>"list"</li></ul><li><b>run:</b></li><ul type="none"><li>Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.</li><li><b>Example: </b>"run" or "run pipeline_name, pipeline_name, pipeline_name"</li></ul><li><b>where:</b></li><ul type="none"><li>Report back the Azure DevOps orgs that are related to this repository and org</li><li><b>Example: </b>"where"</li></ul></ul><br>
See <a href="https://go.microsoft.com/fwlink/?linkid=2056279">additional documentation.</a>
</samp>

@fflaten
Copy link
Collaborator Author

fflaten commented Jun 30, 2022

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@bravo-kernel
Copy link
Collaborator

bravo-kernel commented Jun 30, 2022

One more thing before I sign out for today. If assertions/assertions is indeed the intended default page, don't you think we should change the current sidebar order below? I would expect Assertions Reference to be on top.

image

@fflaten
Copy link
Collaborator Author

fflaten commented Jun 30, 2022

I see your point, but personal opinion is no. It breaks the natural reading flow (think about the next/previous page). A user needs to know the basics of Should before getting overwhelmed by all the assertions 🙂

@bravo-kernel
Copy link
Collaborator

I hear you, just checking ;)

@nohwnd nohwnd merged commit 1e4d6d3 into main Oct 3, 2022
@nohwnd nohwnd deleted the fflaten-patch-1 branch October 3, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants