Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Action to run PSScriptAnalyzer on PR and commit #2221

Merged
merged 5 commits into from Jul 26, 2022

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented Jul 24, 2022

PR Summary

Adds a workflow that scans source code for good practices on commit to main-branch and in pull requests.

Trying GitHub Action first to enable feedback in PRs. If it's too noisy, PR-trigger can be disabled or we could move this to AzDO CI (see example)

Results will show up both in:

  • Security -> Code scanning alerts
    image

  • And as code review/comment for any affected code in pull requests
    image

Fix #1635

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@fflaten fflaten changed the title Add GitHub Action for PSScriptAnalyzer on PRs and commit Add GitHub Action to run PSScriptAnalyzer on PR and commit Jul 25, 2022
@nohwnd nohwnd merged commit 2bcb82e into pester:main Jul 26, 2022
@fflaten fflaten deleted the pssa-action branch July 26, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pester PR Build Pipeline should check for PsScriptAnalyzer errors
2 participants