Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Because to Should -Invoke and -InvokeVerifiable #2229

Merged
merged 4 commits into from Oct 2, 2022

Conversation

fflaten
Copy link
Collaborator

@fflaten fflaten commented Aug 5, 2022

PR Summary

Adds support for -Because in -Invoke and -InvokeVerifiable to be able to customize generic mock assert errors.

Should -Invoke already included the parameter, but the internal method didn't support it and threw a ParameterBindingException.

Fix #2121
Fix #2228

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@fflaten
Copy link
Collaborator Author

fflaten commented Aug 5, 2022

There are slight changes to the error messages from these commands, , but it was + a few commas. I don't consider this a breaking change since I hope only we rely on those in tests. :)

@nohwnd nohwnd merged commit 2454a0e into pester:main Oct 2, 2022
@fflaten fflaten deleted the invoke-because branch October 2, 2022 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants