Add -InParameterSet in Should -HaveParameter

[fflaten]

PR Summary

Adds support for asserting parameter in a specific parameter set.
This only affects whether parameter exists (or not) and if exists in set and mandatory.

Fix #2227

PR Checklist

• PR has meaningful title
• Summary describes changes
• PR is ready to be merged
  • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
• Tests are added/update (if required)
• Documentation is updated/added (if required)

[fflaten]

Just to be clear, Should -Not -HaveParameter abc -InParameterSet 'foo' -Mandatory will still fail if parameter exists regardless of mandatory-requirement as -Not, see #2105

[fflaten]

Pending #2267 to fix CI

[johlju]

This looks good to me. The tests seems to cover all (that I can see) possible variants.

[fflaten]

Not sure about the parameter name. Maybe just -ParameterSet?

[johlju]

Not sure about the parameter name. Maybe just -ParameterSet?

I think -InParameterSet is good enough for now. It makes sense when used together with -HaveParameter. It could be HaveParameterSet if it it should be able to be used standalone, but if it never should be used alone then as-is is good enough. 🙂

Come to think of it we did not have a test case for what happens (should happen) when using -InParameterSet without -HaveParameter, did we?

[fflaten]

Thanks.

It could be HaveParameterSet if it it should be able to be used standalone

Come to think of it we did not have a test case for what happens (should happen) when using -InParameterSet without -HaveParameter, did we?

-HaveParameter is the assertion/operator name so it's mandatory (like -BeTrue etc).

The reason I'm unsure is that we normally use -Mandatory (not -IsMandatory) and -DefaultValue (not -HasDefaultValue). On the other hand, this operator already use -HasArgumentCompleter so it's already special. 🤷‍♂️ 🙂

-InParameterSet felt more intuitive since it's used as a single-value filter for the operator. -ParameterSet could read like it accepts an array of set names (as an assertion).

[johlju]

-InParameterSet felt more intuitive since it's used as a single-value filter for the operator. -ParameterSet could read like it accepts an array of set names (as an assertion).

I agree.

[fflaten]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).