Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Run.Exit option clarification #2346

Merged
merged 1 commit into from May 10, 2023
Merged

Add Run.Exit option clarification #2346

merged 1 commit into from May 10, 2023

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented May 10, 2023

PR Summary

Improve wording for Exit option.

Fix #2338

PR Checklist

  • PR has meaningful title
  • Summary describes changes
  • PR is ready to be merged
    • If not, use the arrow next to Create Pull Request to mark it as a draft. PR can be marked Ready for review when it's ready.
  • Tests are added/update (if required)
  • Documentation is updated/added (if required)

@nohwnd
Copy link
Member Author

nohwnd commented May 10, 2023

@fflaten I am not super happy about the wording, but I tried to keep it concise.

I was also adding an example, but it feels like I am polluting the documentation with a nuanced edge case that needs a lot of explanation, and it is probably easier to find the issue on github.

Copy link
Collaborator

@fflaten fflaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 If we need to say more, incl examples, it belongs in a CI-usage page on the website imo.

@nohwnd nohwnd merged commit 08a1e00 into main May 10, 2023
14 checks passed
@nohwnd nohwnd deleted the exit-clarification branch May 10, 2023 13:43
fflaten pushed a commit to fflaten/Pester that referenced this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoke-Pester reports negative exit code, despite: Exit = $false
2 participants