New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize TestResuls-code into format-specific files #2348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PSScriptAnalyzer found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
@@ -301,7 +287,7 @@ | |||
$stringWriter = $null | |||
$xmlWriter = $null | |||
try { | |||
$stringWriter = & $SafeCommands["New-Object"] IO.StringWriter | |||
$stringWriter = & $SafeCommands['New-Object'] IO.StringWriter |
Check notice
Code scanning / PSScriptAnalyzer
The built-in *-Object-cmdlets are slow compared to alternatives in .NET. To fix a violation of this rule, consider using an alternative like foreach/for-keyword etc.`. Note
@@ -555,7 +374,7 @@ | |||
$stringWriter = $null | |||
$xmlWriter = $null | |||
try { | |||
$stringWriter = & $SafeCommands["New-Object"] IO.StringWriter | |||
$stringWriter = & $SafeCommands['New-Object'] IO.StringWriter |
Check notice
Code scanning / PSScriptAnalyzer
The built-in *-Object-cmdlets are slow compared to alternatives in .NET. To fix a violation of this rule, consider using an alternative like foreach/for-keyword etc.`. Note
Something to consider: Deprecate public |
cc24b4a
to
8437118
Compare
PR Summary
TestResults.ps1
as they're used for both NUnit 2.5 and 3. Same might apply to JUnit4 and ex. JUnit5 in the future.release.ps1
to verify all mandatory files are available in buildGet-HumanTime
toOutput.ps1
where it's usedExit-WithCode
helper.PR Checklist
Create Pull Request
to mark it as a draft. PR can be markedReady for review
when it's ready.