BeforeEach / etc enhancements, and Should Be bug fix #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Figured out how to make this work on v3+. It required a little bit more futzing around with Reflection and internals, but what can ya do. Also fixed a bug in Should Be: several string parameters were marked as mandatory but did not allow an empty string for the input that was piped to Should.
dlwyatt
added a commit
that referenced
this pull request
Apr 28, 2015
BeforeEach / etc enhancements, and Should Be bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #329 and #319 included for v3+. Also fixes a bug with Should Be / Should BeExactly where they would blow up if empty strings were piped in.