Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Powershell spelling to PowerShell #201

Closed
wants to merge 1 commit into from

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jun 20, 2022

Fix spelling of PowerShell

@SQLDBAWithABeard happy? 馃榿

@bravo-kernel
Copy link
Collaborator

馃挕 looks good to me 馃挕

馃う

@bravo-kernel
Copy link
Collaborator

bravo-kernel commented Jun 20, 2022

One exception: the module is called Alt3.Docusaurus.Powershell and these changes will cause unnecessary changes when re-generating the help.

Please revert and I will create an update for the module with PR for docs after.

@bravo-kernel
Copy link
Collaborator

^^

@SQLDBAWithABeard
Copy link

I'm totally happy 馃槉
And created within the keynote as well 馃敟鉂わ笍馃敟

@bravo-kernel
Copy link
Collaborator

Same for the auto-generated get-help pages mr. @nohwnd, IMO those should be reversed as well so I can apply the fix in Alt3.Docusaurus.Powershell.

@bravo-kernel
Copy link
Collaborator

I have released https://www.powershellgallery.com/packages/Alt3.Docusaurus.Powershell/1.0.24 to match expected casing.

@bravo-kernel
Copy link
Collaborator

bravo-kernel commented Jun 24, 2022

@fflaten @nohwnd Perhaps also a good moment to regenerate the command pages using latest Pester version. Currently pester.dev shows the below. Would do it myself but I am occupied by the Alt3.Docusaurus.Powershell module.

Have finally upgraded to Pester 5, so much better and more readable now 馃拑

image

@fflaten
Copy link
Collaborator

fflaten commented Jun 24, 2022

Wait for pester/Pester#2170 馃檪

@bravo-kernel
Copy link
Collaborator

Perfect

@bravo-kernel
Copy link
Collaborator

Please note that simply finding and replacing also broke some links. Perhaps better to close this PR?

@bravo-kernel
Copy link
Collaborator

Closing this in favor of #212. Should make the change a lot simpler.

@fflaten
Copy link
Collaborator

fflaten commented Jun 26, 2022

#212 doesn't cover v4 or non-commandref docs (yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants