Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Unexpanded Test Files do not update status if "Run All" is clicked #14

Closed
AlonGvili opened this issue Aug 9, 2021 · 7 comments 路 Fixed by #31
Closed

馃悰 Unexpanded Test Files do not update status if "Run All" is clicked #14

AlonGvili opened this issue Aug 9, 2021 · 7 comments 路 Fixed by #31
Assignees
Labels
bug Something isn't working

Comments

@AlonGvili
Copy link

image

also when the tests are in the tree view and you click on to run all tests, its only mark the tests that are currently visible in the list as pass or failed, even if you scroll down the list all the others stay gray
and when I click on one test from the list on view file
image

@JustinGrote
Copy link
Collaborator

@AlonGvili thanks, I imagine there's a lot of performance issues with large test suites at the moment, I've only done small-scale testing. Can you provide me your repo for reference so I can test against it?

@JustinGrote JustinGrote added the bug Something isn't working label Aug 9, 2021
@AlonGvili
Copy link
Author

@AlonGvili thanks, I imagine there's a lot of performance issues with large test suites at the moment, I've only done small-scale testing. Can you provide me your repo for reference so I can test against it?

https://github.com/AlonGvili/pwshchakraui

@JustinGrote
Copy link
Collaborator

@AlonGvili this is a known issue if you haven't expanded a test file before clicking "run all". I used to have a warning in there but pulled it out. This is fixable and on the to-do list, but if you expand the tests first everything should work fine. I was able to run all your tests without issue in PS7 (lots of test-level errors but they ran 馃榿).

There's several UI issues around "clicking too fast" and things not refreshing after multiple runs as well, those will get cleaned up.

@JustinGrote JustinGrote changed the title When the tests are in a list view and you click on one it make vscode to crush 馃悰 Unexpanded Test Files do not update status if "Run All" is clicked Aug 9, 2021
@AlonGvili
Copy link
Author

@AlonGvili this is a known issue if you haven't expanded a test file before clicking "run all". I used to have a warning in there but pulled it out. This is fixable and on the to-do list, but if you expand the tests first everything should work fine. I was able to run all your tests without issue in PS7 (lots of test-level errors but they ran 馃榿).

There's several UI issues around "clicking too fast" and things not refreshing after multiple runs as well, those will get cleaned up.

LOL,13 tests failed its a lot?, maybe you can add expand all button...,

@JustinGrote
Copy link
Collaborator

JustinGrote commented Aug 9, 2021

@AlonGvili I have no control over the UI of the test adapter, that'd have to be submitted as a vscode enhancement. My planned fix was that if a test file is called to be run, if it hasn't been "resolved" (expanded) then resolve it first.

For me pretty much every test failed with -encoding parameter not found but I was running it on PS7 :)

@AlonGvili
Copy link
Author

AlonGvili commented Aug 9, 2021

@AlonGvili I have no control over the UI of the test adapter, that'd have to be submitted as a vscode enhancement. My planned fix was that if a test file is called to be run, if it hasn't been "resolved" (expanded) then resolve it first.

For me pretty much every test failed with -encoding parameter not found but I was running it on PS7 :)

me too 7.1.3

update: I know why you get a lot of errors on the test I hardcoded the paths of the files, thanks for the info :)

@JustinGrote
Copy link
Collaborator

So I tried fixing this but I ended up with a race condition with the new debounce method, I'll need to rearchitect and rewire some stuff in how tests are discovered to resolve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants