setup: setup eslint and husky #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karansapolia
requested review from
rishabh1403,
nimish-gupta,
nihalanisumit and
piyushagwl007
karansapolia
force-pushed
the
karan/setup-eslint
branch
from
01f2db1
to
a168f14
Compare
karansapolia
force-pushed
the
karan/setup-eslint
branch
from
a168f14
to
8b8bdcb
Compare
piyushagwl007
approved these changes
Aug 14, 2019
| @@ -13,9 +13,6 @@ | |||
| "test": "react-scripts test", | |||
| "eject": "react-scripts eject" | |||
| }, | |||
| "eslintConfig": { | |||
| "extends": "react-app" | |||
| }, | |||
| "browserslist": { | |||
There was a problem hiding this comment.
Why did you remove it?
nimish-gupta
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3