Prefix bug #7
Open
Prefix bug #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devajmeireles
approved these changes
Oct 10, 2023
|
@devajmeireles The test problem does not sound like a problem on my side, can you have a look at it? |
nunomaduro
requested changes
Oct 10, 2023
| // This is needed to avoid having a prefix like "App" and a namespace like "App\Application\..." | ||
| // This would result in a directory like "\lication\..." | ||
| $posFirstPrefix = strpos($name, $prefix); | ||
| $nameWithoutPrefix = $posFirstPrefix !== false ? substr($name, $posFirstPrefix + strlen($prefix)) : $name; |
There was a problem hiding this comment.
Can you first create a test - that fails prior to this change?
There was a problem hiding this comment.
Tbh I don't really know how to do it, the linked issue shows a problematic environment and I don't know how I create a test case that will use a logic that I overwrite within the same branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically what happend here pestphp/pest#966 was that the plugin created directories with the path
Core/lication/Contractsinstead ofCore/Application/Contractswith the given codeAnd passed because no File was found