Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add database interaction assertions #1

Merged
merged 1 commit into from
May 20, 2020
Merged

Add database interaction assertions #1

merged 1 commit into from
May 20, 2020

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented May 20, 2020 •
edited
Loading

Should be able to rebase this after #3 has been merged. 馃憤

@nunomaduro
Copy link
Member

nunomaduro commented May 20, 2020 •
edited
Loading

Can't I rebase from the UI? 馃槩

@owenvoke
Copy link
Member Author

owenvoke commented May 20, 2020 •
edited
Loading

Don't think so. Give me a sec and I'll do it. 馃憤

That should work. 馃

@owenvoke
Copy link
Member Author

owenvoke commented May 20, 2020 •
edited
Loading

Trying to work out what other assertions should be added.

Looks like most of them are actually on the facades, etc.
https://github.com/search?q=assert+repo%3Alaravel%2Fframework+path%3Asrc&type=Code

@nunomaduro nunomaduro merged commit d8a4e38 into pestphp:master May 20, 2020
@nunomaduro
Copy link
Member

Great, thanks!

@owenvoke owenvoke deleted the feature/database branch May 20, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@owenvoke @nunomaduro