Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pest plugin to documentation #157

Closed
olivernybroe opened this issue Aug 5, 2020 · 13 comments
Closed

Add Pest plugin to documentation #157

olivernybroe opened this issue Aug 5, 2020 · 13 comments

Comments

@olivernybroe
Copy link
Member

The plugin is now getting a stable release and I think it is time for us to actually add it to the website for user's to easily find it.

JetBrains has support for two different iframes which might be useful in docs
image

<iframe frameborder="none" width="230px" height="110px" src="https://plugins.jetbrains.com/embeddable/card/14636"></iframe>

image

<iframe frameborder="none" width="245px" height="48px" src="https://plugins.jetbrains.com/embeddable/install/14636"

ofc. we don't have to use them 👍

@owenvoke
Copy link
Member

owenvoke commented Aug 5, 2020

I feel like it would be nice to create our own component that fits with the rest of the site. But either of those embeds would probably be fine, although that's loading another thing from a remote endpoint. 🤷

Maybe just something like this which is basically just from Tailwind UI: https://tailwind.run/VE8bmN

Probably with the logo to the left side as well. 👍

@olivernybroe
Copy link
Member Author

@owenvoke Yeah, I think our own component would prob. be better 👍 Just wanted to show the option if somebody found them a better fit.

@nunomaduro
Copy link
Member

cc @alexmartinfr

@octoper
Copy link
Member

octoper commented Aug 6, 2020

I might be able to make a component later today.

@alexmartinfr
Copy link
Collaborator

alexmartinfr commented Aug 6, 2020

Now that we have an official PHPStorm plugin, can we assume all issues listed here are solved?

If so, we could turn the pending PHPStorm guide into a broader IDE integration guide:

About the embeddable plugin card:
We can design something better, sure, but I like that they show the number of downloads!

@olivernybroe
Copy link
Member Author

olivernybroe commented Aug 6, 2020

@alexmartinfr We can also use shield.io for the downloads part, they support intellij plugins

I think we can assume all issues listed there are resolved, and if not they should be opened as issues on that repo

@alexmartinfr
Copy link
Collaborator

alexmartinfr commented Aug 7, 2020

Can we extract only the downloads number from the JetBrains website?

If so, we could have a custom design like so, for each plugin:
(I would write a text introduction on top of the page, before throwing the cards).

image

I've reused a "dome badge" CSS class I'm using on my projects to make different logos fit better together.
Also, the card is inspired by some TailwindUI components, and the "download" SVG icon is from Heroicons 👍

@owenvoke
Copy link
Member

owenvoke commented Aug 7, 2020

@alexmartinfr, that looks great! You could probably use their API and just extract the relevant XML attribute?
https://plugins.jetbrains.com/plugins/list?pluginId=14636

It's under the following XML XPath selector:

/plugin-repository/category/idea-plugin[1]/@downloads

@olivernybroe
Copy link
Member Author

olivernybroe commented Aug 13, 2020

@owenvoke that is also how shields.io does it (with the xml) 👍

@alexmartinfr
Copy link
Collaborator

Shootout to @octoper who is working in the dark to bring this to life! 👍

@octoper
Copy link
Member

octoper commented Sep 20, 2020

This is gonna be included in the new Pest Website

@olivernybroe
Copy link
Member Author

@octoper looking sooo forward to that 👍

@octoper
Copy link
Member

octoper commented Sep 24, 2020

@olivernybroe I think that you can close that issue because the page has been added to the new website!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants