-
-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing support to Infection PHP #4
Comments
I might take a quick look at this tomorrow, just to see how it's done. 👍 |
Right, I've taken a look and this is probably going to be complicated. New adapters are created as an additional repository, I was thinking of a However it looks like the But after that, and some tweaking (hacks?)... |
@owenvoke I guess we can create our own repository for this. Let's call it |
This afternoon I going to create the template for that repository. Give me a couple hours. |
It looks like the only changes we'd need to PR to Infection is to add a Pest constant and entry to the |
Hello, Infection's creator here. Thanks for looking into this and creating this issue. @owenvoke can you please share an adapter you created for Pest? I wonder how you deal with Regarding adapter: I would suggest creating an official repository at
You can be maintainers of this repo if that matters. Why "official" repository is better? because
FYI, adapters should have a special composer package's type Didn't dig into the Pest yet, but test framework should have some required features to be able to work efficiently with Infection, some of them are described here infection/infection#45 (comment). I guess if the Pest is just a wrapper for PHPUnit and works with PHPUnit's config, it shouldn't be an issue. Anyway, I'm happy to help here. |
@maks-rafalko I think it's also an opportunity to adapt the config locator. I don't think it makes sense anymore to have it in the core with hard-coded path when its responsibility is to locate the test framework config path, which depends on the test framework itself. One way would be to move the interface directly in https://github.com/infection/abstract-testframework-adapter or it could even be completely hidden in the adapter, leaving the responsibility to have a dedicated class for that or not to each individual adapters. A non trivial question though is how all of that should interact with the |
Alright, I love infection - but at the moment I've no plans to work on this. Hopefully in the future someone will pick this. |
Missing a sad smiley. But you are the maintainer, it's your call. |
@tomasnorre Yeah - unfortunately my free time is very limited. And of course, someone else that needs infection in their test suite can submit a pull request that addresses this issue. |
I totally get that, I wasn't meant as a blame, was just hoping for it. We just started using pest and I think that mutation tests are really valuable. Perhaps I get to the point where I will make a PR. But like you, I have limited free time too :) Stay safe and take care. |
Infection is a PHP mutation testing framework based on AST (Abstract Syntax Tree) mutations: https://infection.github.io/guide.
Problem: When running Infection against a test suite written in Pest, Infection will use the
phpunit
binary instead causing the following exception:How to fix this issue: Develop a Pest adapter and pull request it to the Infection repository.
The text was updated successfully, but these errors were encountered: