[2.x] Allow string type in greaterThan/lessThan expectations #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulsn-mapon
force-pushed
the
feature/string-comparison-expectations
branch
from
b4a510c
to
b1c59ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Since the time type annotations were added to these assertions:
toBeLessThantoBeLessThanOrEqualtoBeGreaterThantoBeGreaterThanOrEqualthey only allowed
int|float(and more recentlyDateTimeInterface) values as the comparators. However, PHP also has semantics for string comparison which were not taken into account.This PR adds the appropriate annotation to the expectation so that strings can also be compared among themselves.
Please feel free to adjust the PR to your liking or request changes. Thanks!